Is there a bug in nmon_helper.sh related to checking for running nmon instances?

[tsteens]

Hi,

I have just installed version 1.5.19 of this script. As far as I can see there is at least two places where the check towards $? is done following an echo statement. As far as I have figured out this causes the test to be successful unless echoing to the screen fails for some reason and that is not the intention.

The ones I've found are in 2.1.1:

for p in ${PIDs}; do

                    echo "`date`, Found Nmon instance running with PID ${p}, will verify if it is App related"

                    if [ $? -eq 0 ]; then

and in 2.1.2.2

verify_pid $p | grep -v grep | grep ${APP_VAR} >/dev/null

                        echo "`date`, Found Nmon instance running with PID ${p}, will verify if it is App related"

                        if [ $? -eq 0 ]; then

The latter is killing off any nmon sessions I have running which is inconvenient.

Is it possible to fix this?

Best regards,
Tommy

[tsteens]

Thank you for fixing this quickly. Love the app by the way.

[guilmxm]

Hello,

You are welcome, and thank you 🙂

For information, i have release the Version 1.4.24, between other, this is is an important update for the nmon_helper.sh which used to be a root cause of trouble, specially for people like you having other Nmon instances running on same hosts.
The script won't try to kill anymore any process, but focus on better process identification.

Don't hesitate to inform me in case of trouble.

Guilhem

[guilmxm · Accepted solution]

Hi,

The corrective release has been published under the version 1.5.20, available in Splunk App:

https://splunkbase.splunk.com/app/1753/

This is indeed a correction of the nmon_helper.sh script (stupid errors...), based on every tests i could ran, it should not kill anymore non App related nmon process.

In the contrary, please do not hesitate to contact me directly to definitively solve this annoying border effect.

Guilhem

[guilmxm]

Hello,

Ouch ! You are totally right, this will be fixed very shortly.
Sorry for this.

Will update this topic.

Guilhem

[tsteens]

Thank you for the quick reply!