check_for_secret_disclosure in External API call problem

glt-suzuki — Mon, 09 Sep 2024 10:31:13 GMT

We are developing a Splunk app that uses an authenticated external API. In order to support the Cloud Platform, we need to pass the manual check for the cloud tag, but the following error occurred, and we couldn't pass.

================

[ manual_check ] check_for_secret_disclosure - Check for passwords and secrets.

details: [ FAILED ] key1 value is being passed in the url which gets exposed in the network. Kindly add sensitive data in the headers to make the network communications secure.

================

code:

req = urllib.request.Request(f"https://api.docodoco.jp/v6/search?key1={self.apikeys['apikey1']}...
req.add_header('Authorization', self.apikeys['apikey2'])

We understand that confidential information should not be transmitted via HTTP headers or POST and should not be included in URLs. Since "key1" is not confidential information, we believe there should be no issue with including it in the URL.

Due to the external API's specifications, "key1" must always be included in the URL, so we are looking for a way to pass this manual check.

For example, if there is a support desk, we would like to explain that there is no issue with the part flagged in the manual check. Does anyone know of such a support channel? Alternatively, if there is a way to provide additional information to reviewers conducting this manual review, we would like to know. (For example, adding comments to the source code, etc.)

topic check_for_secret_disclosure in External API call problem in Splunk Dev

check_for_secret_disclosure in External API call problem